[MPlayer-dev-eng] [PATCH] revert CPU speed detection

Aurelien Jacobs aurel at gnuage.org
Thu Oct 7 20:02:50 CEST 2004


On Thu, 7 Oct 2004 04:34:50 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> Hi!
> 
> I've had a look at a way to make the CPU speed detection run only in
> verbose mode but then reconsidered.  Speed detection has never worked
> reliably and slows down startup noticeably.

Maybe an explaination of GetCpuSpeed reliablility. The rdtsc instruction
is not serializing which may mean that edx:eax registers have still not
been updated at the time the seepd is caculated ? This seems a bit silly
to me, but the attached patch makes cpu speed detection more reliable.

This don't mean that cpu speed detection is useful or should be kept.
But the fact that it's not reliable is a bad argument.

Aurel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cpuspeed-fix.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041007/bd313a9f/attachment.asc>


More information about the MPlayer-dev-eng mailing list