[MPlayer-dev-eng] [PATCH] revert CPU speed detection

Diego Biurrun diego at biurrun.de
Fri Oct 8 02:43:56 CEST 2004


D Richard Felker III writes:
> On Fri, Oct 08, 2004 at 01:20:32AM +0200, Diego Biurrun wrote:
> > D Richard Felker III writes:
> > > On Thu, Oct 07, 2004 at 11:31:47AM +0200, Diego Biurrun wrote:
> > > > D Richard Felker III writes:
> > > > > On Thu, Oct 07, 2004 at 04:34:50AM +0200, Diego Biurrun wrote:
> > > > 
> > > > The patch is clean and easy to verify.  How can I make such bold
> > > > claims?  I did not create the patch myself, CVS did it for me.
> > > > 
> > > > Just look at the "cvs diff" headers:
> > > > 
> > > > The first hunk was created by
> > > > 
> > > >   cvs diff -r 1.31 -r 1.29 cpudetect.c
> > > 
> > > did you even check what patch 1.31 is? i expect 1.29->1.30 was the
> > > speed crap and 1.30->1.31 was something actually useful. reversing
> > > them together is nonsense!
> > 
> > You expect wrong.  Did YOU even check what 1.31 is?  I did.  It's sad
> > that this possibility does not appear to have crossed your mind.
> 
> yes, i checked later, and saw that it was a 10l in the original patch.
> fair enough. it would have been nice to mention that. i wasn't trying
> to insult your intelligence, it's just that lots of people here don't
> know how to use cvs right, and that often includes me. now that i
> think about it though you probably know cvs better than most of us
> here.

OK, I'm afraid I overreacted a bit myself, sorry for that.  Anyway,
apologies accepted, no grudges held :)

> anyway let's just decide on what to do..

Yes.  I'll write another constructive reply so we can get this over
with.

Diego




More information about the MPlayer-dev-eng mailing list