[MPlayer-dev-eng] [PATCH] make --disable-mp3lib etc working
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Oct 9 16:57:09 CEST 2004
Hi,
>>> this patch by <basic (at) mozdev (dot) org> fixes compiling with
>>> --disable-mp3, --disable-liba52, --disable-libmpeg2.
>>> See also bugzilla bug #102.
>>> If nobody objects I will apply on friday.
Forgot to say that I applied it.
>>
>> I'm lazy to check by myself so I will ask here;)
>> does the mpeg_ts demuxer call liba52 function, and is this the reason to
>> #ifdef it?
>
> yes, during the probing phase I call a52_syncinfo() to check if a
> portion of
> bytes is a valid a52 frame.
So, is the #ifdef acceptable? Does libdts also provide this function?
Should it be changed to
#if USE_LIBA52 || USE_LIBDTS ?
>> Don't forget that libdts is also done somewhere else and both
>> liba52 and libdts are available through libavcodecs.
I didn't actually know that... But the old version wasn't right either...
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list