[MPlayer-dev-eng] Re: "dev-CVS-040828-23:58-3.2" data on builds incorrect

[Torinthiel]

On Sun, Oct 10, 2004 at 01:28:19PM +0100, J. Grant wrote:
> >or change into your build dir and do ./mplayer
> 
> $ pwd
> /home/now3d/mplayer/main
> $ ./mplayer
> MPlayer dev-CVS-040828-23:58-3.2 (C) 2000-2004 MPlayer Team
> 
> The fault is because version.sh does not called everytime ./configure is
> run. So when I do:
> 
> cvs update -d
> ./configure
> make
> 
> it will still be using the old version.h !

You have seriously quirked your build system if that is true.
According to Makefile, version.h is required by 'all' (and if you type
'make' that's what you're building). Also every object and library
depends on version.h and building version.h runs 'make distclean'
(see Makefile, line 362).

> Unless I do "make distclean", which clears all the crud and makes me
> completely rebuild.

You don't need to. Generating version.h does it.

> Is there a reason configure does not update the version.h timestamp?
> Would a patch be accepted to update version.h when configure is run?

Yes, Makefile does it. IMHO no, as running it in Makefile is more
general. Suppose you update something and don't run configure. If
version.h is updated by configure it won't get run. But if run by
Makefile then the version gets updated correctly.

Now go and check what have you changed that it doesn't.
If you update a file, no matter whether in subdirectory or in main, make
sees it needs to update corresponding .a or .o file. Then it sees that
this file depends on version.h and generates version.h, which in turn
runs make distclean.
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041010/9dad86d3/attachment.pgp>