[MPlayer-dev-eng] [patch] dpms issue with newer xscreensaver

Alexander Strasser eclipse7 at gmx.net
Mon Oct 11 17:13:34 CEST 2004


Jindrich Makovicka wrote ( On Mon, Oct 11, 2004 at 12:31:08PM +0200 ):
> newer versions od XScreensaver now come with a brand new (mis)feature. 
> XScreensaver now also takes care of the DPMS setting in xfree, and 
> periodically checks the DPMS status, reverting it to the state which is 
> set in the XScreensaver configuration file. This is done regardless of 
> pinging or not pinging it. For mplayer it means that if DMPS is set to 

First of all, that sounds bad to me.

> ON in xscreensaver, which is reasonable, after a few minutes of movie 
> playing, temporarily disabled DPMS is re-enabled and eventually the 
> screen goes black in the middle of a movie.
> Probably the simplest solution is to add another call of DPMSdisable to 
> ping_xscreensaver function (see the patch).

Yeah maybe, can't think of sth else atm though is not especially nice and
clear.

> --- x11_common.c.orig	2004-08-26 12:08:30.000000000 +0200
> +++ x11_common.c	2004-10-11 12:23:47.000000000 +0200
> @@ -1570,6 +1570,11 @@
>          memset(&ev.xclient.data, 0, sizeof(ev.xclient.data));
>          ev.xclient.data.l[0] = (long) deactivate;
>  
> +	if (dpms_disabled) {
> +	    Status stat;
> +	    stat = DPMSDisable(mDisplay);
> +	}

The stat var seems useless, I'll remove it if I commit this solution.

  Alex (beastd)




More information about the MPlayer-dev-eng mailing list