[MPlayer-dev-eng] [PATCH] Fix demux_mov on 64-bit platforms

[Timo Teräs]

On Mon, Oct 11, 2004 at 06:56:31PM +0200, Reimar Döffinger wrote:
> >Please review and commit attached patch (it is mostly a search/replace of 
> >long
> >to int with few exceptions on loader/qtx/qtxsdk/components.h). It has also
> >minor fix for vd_ffmpeg.
> 
> Do they all have to be changed? That's really tons of them :-(
> Anyway, I personally would prefer to change them to int32_t, that will 
> also make clear that they have to have exactly this size...

I'm pretty sure they all need to changed. The reason is that all the
structures have __packed__ attribute and they seem to correspond to stream
data. Atleast the segfault reason turned out to be that the size to
allocate struct ImageDescription is read from the .mov header and then
blindly used.

Now that I check there seems to be a bunch of typedefs in the beginning of
the header for different bit-width variables, but oddly they are used only
in few places.

It might be useful to replace all short/int/long to appropriate typedef in
that header.

Cheers,
  Timo