[MPlayer-dev-eng] [PATCH] subtitle reload, slave mode - 2nd try

Salvatore Falco sfalco at studenti.ing.uniroma1.it
Wed Oct 13 10:12:41 CEST 2004


On Tue, Oct 12, 2004 at 08:32:24PM -0400, kiriuja wrote:
> Do you think you could change the command to be like so:
> 
> sub_reload <subtitle_file> [<subtitle_index>]
>     Substitutes subtitles at zero-based index <subtitle_index> (defaults to zero)
>     with subtitles from file with absolute path <subtitle_file>
> 
> This would make more sense, particularly in a situation where only
> one subtitle file is used.

    Please, read my proposal in the other mail I sent. The problem I have with
your approach is that the position a subtitle is loaded to is never communicated outside,
so the user (or the program communicating through the slave mode) shouldn't know
it. It is obvious that, if a single sub is loaded, it is at position 0, but
the user shoudn't rely on this information.
    Furthermore, I would prefere to implement a human-friendly command, so
it's better to use names, rather than numbers.

    Let me know any consideration on this argument.
    
    Best regards,
	Salvatore Falco




More information about the MPlayer-dev-eng mailing list