[MPlayer-dev-eng] [PATCH] Updated playback-speed-changing-patch

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Oct 14 11:22:05 CEST 2004


Hi,
I updated the most recent version of that patch I had to current CVS. 
The changes I made include: Cutting down the size of the status line, as 
it wouldn't fit on a 80 column line, making it scroll through the 
screen, and changing
osd_show_speed  = (playback_speed * sh_video->fps);
to
osd_show_speed  = sh_video->fps;
Although the former looks correct, it caused some weird behavior (at 
around speed 0.2 the speed-osd would only flicker shortly).
In addition it would be inconsistent with the remaining OSD code. If 
really necessary all of it should be fixed.
Otherwise it looks ok to me, but it should be tested with more aos - 
preferrably also with valgrind, as memleaks in the ao's init could 
become troublesome with that patch + people playing around with it ;-)

Greetings,
Reimar Döffinger
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: playback_speed.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041014/c25e2682/attachment.txt>


More information about the MPlayer-dev-eng mailing list