[MPlayer-dev-eng] [PATCH] printf --> mp_msg transition (multiple files)

[The Wanderer]

Reynaldo H. Verdejo Pinochet wrote:

> On Fri, Oct 15, 2004 at 08:29:20PM -0400, The Wanderer wrote:
> 
>> The attached patch handles the printf --> mp_msg (etc.) transition
>> for divx4_vbr.c, fifo.c (just one message), find_sub.c, and
>> m_config.c.
> 
> It seems that youre being to careful setting some messages to
> MSGT_FIXME when the mean of the message is clear, ie, you can asume
> an "out of memory" is a (fatal?) error, dont need to use FIXMES
> everywhere, besides, I pretty much doubth those fixmes will _ever_ be
> 'fixed'.

It's mostly that if I decide to make any of those decisions myself, I'm
likely to start making too many of them, and make some of them
incorrectly - and someone coming along later will have less of a chance
of realizing that the MSGL in question was not chosen by someone who
knows what they're doing.

If necessary, if no one more competent (or at least more familiar with
the code) starts going through and correcting the MSG?_FIXMEs, I may
start doing that myself after the printfs are all gone. In the meantime,
however, in the absence of more pressure to do otherwise I think I'll
stick with my current policy.

> i have done some printf->mp_msg work too, please correct me if im
> wrong, coz if so, some of my patches will need rewritting too.

In practice, I think that a patch which used inappropriate MSGLs would
quite possibly get rejected, so it's probably safe enough. I'm just
paranoid.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.