[MPlayer-dev-eng] [PATCH] XviD: choose the name of the 1st pass stat file

[Guillaume POIRIER]

Hi,

Le dim 17/10/2004 à 14:50, Ivan Kalvachev a écrit :
> On Wed, 13 Oct 2004 16:02:50 +0200
> Guillaume POIRIER <guillaume.poirier at etudiant.univ-rennes1.fr> wrote:

> > I'd really appreciate if you could stop using that tone with me. You 
> > really have to understand that I'm just trying to help, ever if my help 
> > is somehow/sometimes unappropriate.
>  
> OK, DonDiego told me that my previous mail have been a little bit more
> offensive than I have planed to, so I would like to appologise.

Apologizes accepted! ;-)


> You could be sure that I take care of XviD4 module 
> and that I have agreement with GomGom about it. I get all
> the changes from him.
> 
> I will review any patch that is your own. No worries about it.
> 
> For example, some of the default values of options were rejected
> because there were no way to turn them off, if you want to add
> no-options, i would welcome it.

Ok, I'll try to find some time to work on that. Is that enough to add
something like :
{"nochroma_opt", &xvidenc_nochroma_opt, CONF_TYPE_FLAG, 0, 0, 1, NULL},

and something like:
if(xvidenc_nochroma_opt) {
   frame->vop_flags &= ~XVID_VOP_CHROMAOPT;
}

to libmpcodecs/ve_xvid4.c ?
Is there a way to tell the front-end that some options are mutually
exclusive?

> BTW You are free to work on XviD4 documentation as I don't like
> documenting features.

Thanks... That's how I started working with the MPlayer team you know!
What do you think about it? ;-)

Guillaume