[MPlayer-dev-eng] [PATCH] Extended DVD-arguments

[Carl Fûrstenberg]

On Mon, 18 Oct 2004 15:38:27 -0400, D Richard Felker III
<dalias at aerifal.cx> wrote:
> On Mon, Oct 18, 2004 at 07:49:43PM +0200, Carl Fûrstenberg wrote:
> >
> > so you propose a bypass operation in parser-mpcmd.c if string isn't dvd://%d-%d?
> 
> uhg, is it that ugly? actually i'd propose removing the multi-title
> syntax but someone would complain that "removing functionality" isn't
> allowed.
> 
> 
> 
> rich
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 


The problem now is that the string is parsed two times, first in
parser-mpcmd.c, and later the same string, ur a converted one is
parsed in libmpdemux/open.c
in open there is references to device, one title, angle and chapters,
and in parser-mpcmd.c first an last title is parsed.
The one who wrote that had possibly a perfect goal with it, but if you
look at the original design (before my patch) parser-mpcmd.c when it's
done creates a ned dvd://-string that open.c later handles.
For me it looks like it was an attemt to change the design, but it
halted in the middle'

One alternative is to change so instead creating a new dvd://-string,
it sends an array to open.c (ok, there is something in between, havent
figured out the whole travers yet).

But if I could remove the multiple title argument, then the problem is
solved. (I think),

If we for now think a bit practical, what is the user moslty intrested
to control? be able to view title 1 to 4 in one argument, or be able
to watch chapter 4 to 8 in simlar argument? most dvd's have one main
title.