[MPlayer-dev-eng] [PATCH] XviD: choose the name of the 1st pass stat file

[D Richard Felker III]

On Mon, Oct 18, 2004 at 12:53:05PM -0700, Loren Merritt wrote:
> On Mon, 18 Oct 2004, Guillaume POIRIER wrote:
> >Le dim 17/10/2004 à 14:50, Ivan Kalvachev a écrit :
> >
> >>For example, some of the default values of options were rejected
> >>because there were no way to turn them off, if you want to add
> >>no-options, i would welcome it.
> >
> >Ok, I'll try to find some time to work on that. Is that enough to add
> >something like :
> >{"nochroma_opt", &xvidenc_nochroma_opt, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> >
> >and something like:
> >if(xvidenc_nochroma_opt) {
> >  frame->vop_flags &= ~XVID_VOP_CHROMAOPT;
> >}
> 
> No need for a separate variable. From ve_x264.c:
>   {"cabac",   &cabac, CONF_TYPE_FLAG, 0, 0, 1, NULL},
>   {"nocabac", &cabac, CONF_TYPE_FLAG, 0, 1, 0, NULL},
> 
> >Is there a way to tell the front-end that some options are mutually
> >exclusive?
> 
> I don't think so.

imo if both have the same pointer and both are CONF_TYPE_FLAG, they're
mutually exclusive. more cases like this can be worked out too..

rich