[MPlayer-dev-eng] Patch: Jack audio output

[Reimar Döffinger]

Hi,

>>> We can do, but the actual API changed in bio2jack to make it an 
>>> unsigned char...  For whatever reason we aren't loading the 
>>> bio2jack.h file and instead portions of it are reproduced here 
>>> directly...
>>
>> Don't know why, I wouldn't mind changing it, although people will have
>> to have it lie around somewhere like this...
> 
> OK, well since it is working today, and if you aren't going to add in 
> the bio2jack.c file as well, then I propose that we consider to 
> basically agree to do it, but lets put it on hold until the API settles 
> down a little and there seems to be a reason to do it.  Sound OK?
> 
> 
>> Now that there are bio2jack releases and not only CVS everyone can
>> downgrade to the last release if it breaks...
>> Having bio2jack directly included would require someone regularly
>> updating it - a waste of developer time at least I won't be happy with,
>> which is why it was already refused at the time of first commit.
>> And when I look at what a mess every update of libfaad or libmpeg2 seems
>> to cause I am even more against it.
> 
> I'm only going to lightly protest and say that the author feels that for 
> such a small library it seems silly to build it as a shared library.  We 

Just to clarify: A shared library is a .so file, while MPlayer afaik 
links (statically) against against the .a file.

[...]
>> Here you use spaces instead of tabs for intendation... that makes the
>> code look bad with a different tabsize...
> 
> Aha, ooops.  Sorry, I did try quite hard to keep tabs wherever possible 
> since that is what was used originally.  Do you need me to resubmit this 
> patch with the tabs changed?
> 
> So barring the tabs to spaces change, is this good to commit?

I can't test or anything. I only commented the "cosmetic" part. Could 
somebody comment the functional part? E.g. the original author of that code?

Greetings,
Reimar Döffinger