[MPlayer-dev-eng] [PATCH] subtitle reload, slave mode - 3rd try

Diego Biurrun diego at biurrun.de
Thu Oct 21 03:23:57 CEST 2004


Salvatore Falco writes:
> 
> +sub_load <search> [<replace>]
> +    Subtitles contained into file <replace> are added, or substitute those loaded from <search>, if present.
> +    When only <search> argument is given, <search> is used instead of <replace>.

I think what you are trying to say can be expressed more clearly
through the following:

sub_load <filename> [filename2]
    Replace all currently loaded subtitle files with <filename>. If
    [filename2] is given, replace subtitle file [filename2] with
    subtitle file <filename>.

Thinking about it, I think you implement it differently.  The first
argument should always be the new subfile.  IIUC in your approach the
new subfile can be the first or the second argument depending on the
number of arguments.

So I suggest you implement the specification given by the
documentation snippet above ;-)

Diego




More information about the MPlayer-dev-eng mailing list