[MPlayer-dev-eng] [PATCH] segfault in vf_scale

[Reimar Döffinger]

Hi,

> > especially in combination with -vf pp, vf_scale can segfault because the
> > mpis can have different height, especially when height is not divisible
> > by 16.
> 
> huh? imo this shouldn't happen... if it does i'd consider it a bug, or
> more like a bug in the whole vf layer, which is very possible..

Not sure if you understood me correctly, I wasn't very precise. From
what I can see, the decoder can ask for an mpi that is larger the actual
image size. But when vf_scale does no scaling, it allocates a output mpi
of the real video size - wich will be too small when it tries to convert
mpi->h lines.
A solution could be to save the height from the config call and use that
instead...
Also the question is, which value should mpi->h contain? And which one
mpi->height? They currently see to be used for the same things, which
makes <0 sense to me :-(

Greetings,
Reimar Döffinger