[MPlayer-dev-eng] [PATCH] Extended DVD-arguments

[Carl Fûrstenberg]

On Thu, 21 Oct 2004 17:19:40 -0400, D Richard Felker III
<dalias at aerifal.cx> wrote:
> On Thu, Oct 21, 2004 at 10:01:16PM +0200, Carl Fûrstenberg wrote:
> 
> 
> > On Wed, 20 Oct 2004 10:44:48 +0200, Carl Fûrstenberg <azatoth at gmail.com> wrote:
> > > Hmm, no comments?
> > >
> > > For me the patch works, but perhaps you disslike the bypass operation...
> > >
> >
> > Felker: was it like this you ment?
> 
> yes it's what i meant, but all the cosmetic changes to parser are
> unneeded and will earn you the wrath of many developers... :)
> 
> just change the minimal amount needed (the if at the beginning) and
> leave the rest of the code alone. or if there's something broken in
> the other part, fix it as a second, separate patch.
> 
> 
> 
> rich
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 

yea, you are right there, I wasn't sure in the beginning if the if was
enough, but it seems it's so :-/ ( I thought first I had to check also
after parsing, and thy I did rewrite the parsing)