[MPlayer-dev-eng] [PATCH] Extended DVD-arguments

D Richard Felker III dalias at aerifal.cx
Fri Oct 22 03:50:36 CEST 2004


On Fri, Oct 22, 2004 at 02:27:56AM +0200, Carl Fûrstenberg wrote:
> On Thu, 21 Oct 2004 17:19:40 -0400, D Richard Felker III
> <dalias at aerifal.cx> wrote:
> > On Thu, Oct 21, 2004 at 10:01:16PM +0200, Carl Fûrstenberg wrote:
> > 
> > 
> > > On Wed, 20 Oct 2004 10:44:48 +0200, Carl Fûrstenberg <azatoth at gmail.com> wrote:
> > > > Hmm, no comments?
> > > >
> > > > For me the patch works, but perhaps you disslike the bypass operation...
> > > >
> > >
> > > Felker: was it like this you ment?
> > 
> > yes it's what i meant, but all the cosmetic changes to parser are
> > unneeded and will earn you the wrath of many developers... :)
> > 
> > just change the minimal amount needed (the if at the beginning) and
> > leave the rest of the code alone. or if there's something broken in
> > the other part, fix it as a second, separate patch.
> > 
> > 
> > 
> > rich
> > 
> > _______________________________________________
> > MPlayer-dev-eng mailing list
> > MPlayer-dev-eng at mplayerhq.hu
> > http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> > 
> 
> hmm, was thinking, shouldn't the title-last_title also handle @device?

i suppose it could, but imo the dvd://M-N notation should be
considered legacy. it's a very bad hack in the command parser to begin
with, since each url on the command line should correspond to exactly
one playtree entry.

rich




More information about the MPlayer-dev-eng mailing list