[MPlayer-dev-eng] [PATCH] Extended DVD-arguments
Carl Fûrstenberg
azatoth at gmail.com
Fri Oct 22 16:47:19 CEST 2004
On Thu, 21 Oct 2004 17:19:40 -0400, D Richard Felker III
<dalias at aerifal.cx> wrote:
> On Thu, Oct 21, 2004 at 10:01:16PM +0200, Carl Fûrstenberg wrote:
>
>
> > On Wed, 20 Oct 2004 10:44:48 +0200, Carl Fûrstenberg <azatoth at gmail.com> wrote:
> > > Hmm, no comments?
> > >
> > > For me the patch works, but perhaps you disslike the bypass operation...
> > >
> >
> > Felker: was it like this you ment?
>
> yes it's what i meant, but all the cosmetic changes to parser are
> unneeded and will earn you the wrath of many developers... :)
>
> just change the minimal amount needed (the if at the beginning) and
> leave the rest of the code alone. or if there's something broken in
> the other part, fix it as a second, separate patch.
>
>
>
> rich
>
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>
ok, removed all "cosmetic changes", havn't add the
title-lasttitle at device as you said it should be legacy.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer_dvd_arg.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041022/e08b231a/attachment.txt>
More information about the MPlayer-dev-eng
mailing list