[MPlayer-dev-eng] Stuck mouse buttons

[Reynaldo H. Verdejo Pinochet]

On Sat, Oct 23, 2004 at 01:59:56PM +0200, Diego Biurrun wrote:
Content-Description: message body text
> D Richard Felker III writes:
> > On Fri, Oct 22, 2004 at 02:12:04AM +0200, Diego Biurrun wrote:
> > > The Wanderer writes:
> > > > Diego Biurrun wrote:
> > > > 
> > > > > Marius Gedminas writes:
> > > > > 
> > > > >> Occasionally (but often enough to get annoying) when I click a
> > > > >> mouse button on an mplayer window the button gets stuck
> > > > 
> > > > >> I've traced the problem to mplayer_put_key in fifo.c.
> > > > 
> > > > > I just tested this patch and it works as advertised.  We should
> > > > > really fix this ancient bug.  Somebody please review and commit this.
> > > > 
> > > > I'm not sure what "reviewing" consists of in this type of context, aside
> > > > from looking the code over and saying "it looks okay to me" (in which
> > > > case I wouldn't be remotely qualified to pass on it), but at the very
> > > > least the printfs it adds to fifo.c will need to be changed to mp_msg.
> > > 
> > > Yes, you're right.  In this case the printfs look like mere debugging
> > > aids, though, so I would guess commenting them out (like the others in
> > > that file) should suffice.
> > 
> > yes, printf should not be in mplayer output by default. it needs to be
> > commented, conditional, or mp_msg...
> 
> Here's a version with the printfs commented out..
> 
> Diego
I have comed out to find some commented out printf's that could really
be MSGL_DBG4 or so, what would it be of best practice? just
commenting them out or building a correct mp_msg sentence with
a _debug_ message level? im not talking just about this patch
(to be fair i havent even had a look at it ;-) but other small
files or no so important ones like, ie sub_find.c (last one
i looked).

any suggestion will be greatly apreciated.

Regards

    Reynaldo
	
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041026/fc72807b/attachment.pgp>