[MPlayer-dev-eng] [PATCH] fix for -srate bug

[D Richard Felker III]

On Sat, Oct 30, 2004 at 03:35:06PM +0100, Ed Wildgoose wrote:
> >I have found one small bug though.  If I set the "linear_flag" to 1, 
> >and then try to resample from 48K to 44K, then the output is played 
> >back too slowly (as though it doesn't reduce the number of samples 
> >correctly)
> 
> 
> I have done a little more listening, and have no complaints about the 
> lavc resampler so far. 

so was the above issue just pebkac? or..?

> I do notice though that there is a 6dB difference between the internal 
> mplayer high quality resampler and the lavcresampler (lavc is louder).  
> I'm assuming that the internal resampler is deliberately dropping the 
> volume to avoid clipping due to the resampling, but I would have thought 
> that 6dB was a bit extreme (a little over 3 dB should be enough?).  I 
> haven't checked the code though... There seem to be many other places 
> where mplayer drops the volume a bit.
> 
> Have you given any thought as to whether there is any issue here in 
> practice?

i know the old mplayer resampler drops the volume way too much. that's
actually one reason i used the horrible "linint" resampler instead.
the lavc one should be more correct.

> P.S. Would love to switch to this version of mplayer by default, but the 
> current code seems to have an issue with picking the english language 
> audio track on my multi-language DVD's.  I seem to be getting random 
> tracks now... Config/operator error, or known issue...?

i don't think anyone will find this question buried down at the depths
of this thread... :) try posting it as a new topic on -users or
-advusers if you're willing to do some bug-hunting.

rich