[MPlayer-dev-eng] [patch] m_option.h ??

[Reimar Döffinger]

Hi,

> > diff -u -r1.10 m_option.h
> > --- m_option.h	10 Feb 2004 14:32:06 -0000	1.10
> > +++ m_option.h	23 Oct 2004 21:17:52 -0000
> > @@ -252,7 +252,7 @@
> >  inline  static void
> >  m_option_copy(m_option_t* opt,void* dst, void* src) {
> >    if(opt->type->copy)
> > -    opt->type->set(opt,dst,src);
> > +    opt->type->copy(opt,dst,src);
> >    else if(opt->type->size > 0)
> >      memcpy(dst,src,opt->type->size);
> >  }
> >
> 
> I would say it is a typo, but the real question is how many code actually 
> relies on that typo?
> Maybe you could ask albeu, the original author of the code.

Only the "Func Param" and "Func Full" option type can cause problems,
they are the only ones with copy != NULL and copy != set.

Greetings,
Reimar Döffinger