[MPlayer-dev-eng] Re: [PATCH] "frame stepping"

[Reimar Döffinger]

Hi,

> >>>Oh, come on, everybody knows that "shift" is the "any key" ;-)
> >>
> >>Both of these are irrelevant. It doesn't matter if "the ANY key"
> >>will unpause the playback; the point is that there *is* at least
> >>one key, the frame-stepping key, which will *not*. Therefore the
> >>statement as written is inaccurate, which was my entire point from
> >>the beginning.
> >>
> >>(Yes, I am capable of appreciating the intended humor of the past
> >>few posts. It's just that I don't like to see it lead to a point
> >>which was intended quite seriously being ignored. - and how's
> >>*that* for a lexically ambiguous sentence?)
> >
> >Quite good, I don't understand it :-(.
> 
> How about "lead to a situation in which a particular point, which was
> intended quite seriously, gets ignored"? More awkward in at least one
> sense, but perhaps less confusing.
> 
> >I could now argue that the framestep key will actually unpause the
> >video as well, although only for one frame.
> >But as you can see in the manpage, I agreed with you,
> >as I worked your suggestion into the patch before applying...
> >I actually think Stefan misunderstood what your nit was about...
> 
> ...and I misread the man page. Before making the previous post, I
> searched for "any key" and found the description of the pause command
> itself (immediately above) which still uses that phrasing; I assumed
> that the only place the term would appear was in the patch in question,
> and thus that my suggested change had not been made.

Okay, that explains why you couldn't fully enjoy our last mails ;-)

> The Pause command description should probably be updated to reflect the
> new reality, but I'm not sure how to express it without being either
> inaccurate or quite awkward. About the best I've been able to come up
> with is "(any key not bound to another command unpauses)", but that
> feels undesirably verbose and while accurate is also imprecise - most
> keys which *are* bound to other commands will *also* unpause.

Yes, but now they will also execute the command that was boud to them
(although that _could_ be "fixed" via a command filter but I don't think
this is really desired).
I would suggest "pressing again will unpause", not mentioning the other
keys at all... Also, I would suggest changing the description of the
frame stepping command to say "pressing the pause key will unpause"
(although it sounds stupid).

Greetings,
Reimar Döffinger