[MPlayer-dev-eng] [PATCH] -nocfg option

[Diego Biurrun]

D Richard Felker III writes:
> On Sun, Oct 31, 2004 at 01:34:56PM +0200, Oded Shimon wrote:
> > On Sunday 31 October 2004 02:34, Diego Biurrun wrote:
> > > Oded Shimon writes:
> > > > Made a simple braindead patch to have a command line option '-nocfg'
> > > > which makes MPlayer not load the default config files.
> > >
> > > IMO this should be implemented as a general option for both MPlayer
> > > and MEncoder.  Oh, and you forgot to patch the man page.
> > ...annnnnnnnnnd Done. :)
> > 
> > Passes compile, I didn't actually test it though, but it should very likely 
> > work...
> 
> doesn't patches.txt say to always test your patch before submitting?
> if not, it should. saying "i didn't test but i think it'll work" does
> not inspire confidence, and probably makes people really reluctant to
> spend time testing your patch themselves.

It does:

 3. Test the functionality of your patch. We'll *refuse* it if it breaks
    something, even if it extends other features!

Sending in untested patches in unacceptable IMO.

Diego