[MPlayer-dev-eng] [PATCH] Pause after command

[Reimar Döffinger]

Hi,

> > I created a small trivial patch to pause after after seek/fullscreen/etc.
> > unless you have REALLY fast fingers, just about the only way for this patch
> > to effect is when
> > echo -e 'seek 1\npause'
> > is used.
> >
> > I have thoroughly tested the patch. :)
> I just forgot to attach it though....

> Index: mplayer.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/mplayer.c,v
> retrieving revision 1.802
> diff -u -r1.802 mplayer.c
> --- mplayer.c	28 Oct 2004 23:25:17 -0000	1.802
> +++ mplayer.c	31 Oct 2004 17:22:44 -0000
> @@ -3582,6 +3587,8 @@
>      }
>      }
>      mp_cmd_free(cmd);
> +    cmd = mp_input_get_cmd(0,1,1);
> +    if (cmd) if (cmd->id == MP_CMD_PAUSE) brk_cmd = 0;
>    }
>  }

IMHO this is risky because it can cause unpredictable behaviour. Also,
most functions will not work before the stream is unpaused again.
What exactly should this do in which cases?

Greetings,
Reimar Döffinger