[MPlayer-dev-eng] [PATCH] Pause after command

Oded Shimon ods15 at ods15.dyndns.org
Sun Oct 31 23:33:46 CET 2004


On Monday 01 November 2004 00:10, Reimar Döffinger wrote:
> Has nothing to do with MPlayer source, point is, whether the
> mp_input_get_cmd returns NULL or not does not only depend on what the
> user does but also e.g. on the scheduler. I think you are trying to find
> out whether there is a pause command following that belongs to the
> previous command. This is a very ugly way to do it I think.
Well, i looked up the MPlayer source a bit and found that your 
'mp_input_get_cmd' function has a "peek" feature, that you can look what the 
next input is without removing it from the queue, i found it simply perfect 
for this, as you can then check if the next command is pause, and if so, 
parse it like any other command.

> ok, so with this patch MPlayer will play only one frame further instead
> of two when doing something like "echo -e 'seek 1\npause'", right? I'm
> not convinced that that feature is worth adding this - it looks very
> much like a hack to me ;-)
> Feel free to convince me otherwise, though...
Well, its even in the MPlayer wishlist... :)
I know my program (MEncoder frontend) would certainly benefit from this 
'feature'...
its sort of a hack, but not quite... pause is such a simple command and such 
an "afterthought", that giving it the exception of being allowed to run even 
after a command which is supposed to break user input is ok.

- ods15




More information about the MPlayer-dev-eng mailing list