[MPlayer-dev-eng] [PATCH] Removing -jpeg option and parsing -vo jpeg:options instead.

Diego Biurrun diego at biurrun.de
Sat Sep 4 11:38:00 CEST 2004


Ivo writes:
> 
> Any comments, suggestions, flames or nits to pick?

nits ;-)

>  #ifdef HAVE_JPEG
> -	{"jpeg", jpeg_conf, CONF_TYPE_SUBCONFIG, 0,0,0, NULL},
> +    {"jpeg", "-jpeg is deprecated. Use -vo jpeg:options instead.\n",
> +        CONF_TYPE_PRINT, 0, 0, 0, NULL},

You have switched indentation from tabs to spaces here.  I suggest
using tabs to keep the file consistent.

Looks fine otherwise.  You're the maintainer of that code, so if you
think it's fine, commit it.

Diego




More information about the MPlayer-dev-eng mailing list