[MPlayer-dev-eng] [PATCH] unbreak libmpcodecs/ve_x264.c

Ivo ivop at euronet.nl
Wed Sep 15 02:07:08 CEST 2004


On Tuesday 14 September 2004 19:38, Jan Knutar wrote:
> >+#ifdef HAVE_X264
> > #include <stdio.h>
>
> There are several other modules which include headers even if they
> aren't being compiled in. I always thought there was some hidden reason
> that I didn't understand. Is there a reason for it or not?

I don't know for sure, but I don't think so. It's probably due to the fact 
that people start writing their code based on a framework of another 
filter, demuxer, codec, whatever and keep all the includes that were there 
in the original. Some might not be needed for the new code, but they are 
included anyway. Maybe somebody should check all files to see whether they 
include too much or not. Might save some compile time :-)

--Ivo




More information about the MPlayer-dev-eng mailing list