[MPlayer-dev-eng] [PATCH] EDL fix harcoded translatable messages

Diego Biurrun diego at biurrun.de
Fri Sep 17 04:29:04 CEST 2004


Reynaldo H. Verdejo Pinochet writes:
> > That's much better, thank you.  But you just ignored my other
> > suggestions.  OK, they were mostly cosmetic and thus I have applied
> > your patch to my local tree with my modifications, but I would like
> > you to clear up the following comment:
> > 
> > > +int edl_mute_count = 0; /// even number when mute has been matched mute/unmute
> > 
> > What you are trying to say here is shrouded in complete mystery (at
> > least to me), please explain and I will commit your patch.
> Simple, edl mute operations takes 2 slot on the operation queue, one
> mutes, the next _unmutes_, well there are situations when we need to know
> wich of those operations has been done (think on a backward skip,
> or just a skip) to _match_ the entire mute action (mute/unmute). this
> edl_mute_count thingie is a simple int counter that starts in 0 and is
> incremented by each mute operation (mute or unmute) so, by evaluating
> edl_mute_count%2 we can figure out if there are unmatched mute actions.

Committed with some spelling/wording improvements.

Diego




More information about the MPlayer-dev-eng mailing list