[MPlayer-dev-eng] [PATCH] Fix bad key response on svgalib
Diego Biurrun
diego at biurrun.de
Fri Sep 17 17:55:35 CEST 2004
Mikulas Patocka writes:
>
> Mplayer has a bug in responding to keyboard on svgalib. When you hold the
> key (for example seeking arrow or brightness/contrast change) too long and
> release it, not all key presses are processed. When you press another key,
> the reminding keypresses of the previois key are processed.
>
> The bug is caused by the fact that getch2 is called only when handle 0 is
> readable. However, getch2 does its own internal buffering. So when getch2
> buffer contains keypresses, but handle 0 is not readable, keypresses are
> not processed and delayed until another key is pressed.
>
> The patch fixes it so that getch2 is always called (it checks for
> readability of handle 0 on its own).
>
> It also fixes one possible overflow caused by a missing cast.
Applied by Sascha.
Diego
More information about the MPlayer-dev-eng
mailing list