[MPlayer-dev-eng] [PATCH] New VO drivers.

Diego Biurrun diego at biurrun.de
Fri Sep 17 20:22:43 CEST 2004


Ivo writes:
> 
> I will leave vo_pgm and vo_md5 intact for the moment. What path do we have 
> to follow to remove these (since they become obsolete)? To keep the user 
> informed, the only way I see is to delete all content of the functions 
> inside those vo drivers and have preinit() write a message to the console 
> and exit the player.

Well, you could just update vo_pgm and vo_md5, couldn't you?

BTW, why do you reimplement MD5 instead of relying on an external
program?

Otherwise I see nothing wrong (OK, I could start talking about
trailing whitespace, but I won't ;-), yet this means nothing, besides
I did not test it.

> Oh, and I will update the manual page after commiting the code :)

Unless you wish to unleash the wrath of the chief documentation
maintainer ;-)

Diego




More information about the MPlayer-dev-eng mailing list