[MPlayer-dev-eng] [PATCH] mixer index selection for alsa

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Sep 18 16:54:12 CEST 2004


Hi,

>>-      if(mixer_channel) mix_name = mixer_channel;
>>+      if(mixer_channel) {
>>+	 char *test_mix_index;
>>+
>>+	 mix_name = strdup(mixer_channel);
>>+	 if (test_mix_index = strchr(mix_name, ',')){
>>+		*test_mix_index = 0;
>>+		test_mix_index++;
>>+		mix_index = strtol(test_mix_index, &test_mix_index, 0);
> 
> You're messing up indentation here.
> 
>>+      if (mixer_channel) {
>>+	free(mix_name);
>>+	mix_name = NULL;
> 
> same here.

I'll happily change the indentation if you want, but the rest of the 
function uses the same weird way (tab+space or tab+tab+space)
So tell me how you think I should fix it and I'll do it ;-)

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list