[MPlayer-dev-eng] [PATCH] show ogg subtitle language

D Richard Felker III dalias at aerifal.cx
Fri Sep 24 08:55:27 CEST 2004


On Fri, Sep 24, 2004 at 12:49:24AM -0500, Joey Parrish wrote:
> On Thu, Sep 23, 2004 at 09:21:30PM -0500, Joey Parrish wrote:
> > Attached is a patch to demux_ogg to cache the subtitle languages and to
> > main to show them on OSD.  OK to commit?
> 
> No!  Not okay!  :)
> I sent the wrong version, that one didn't compile.  Oops.
> 
> Here's the right one.

ok to commit? depends on if it has buffer overflow vulns (or any other
sort of string vulns). you'd better be damn careful with code like
this, but please do double check it and then commit once you're sure
it's safe. it sounds like a useful feature.

rich




More information about the MPlayer-dev-eng mailing list