[MPlayer-dev-eng] [PATCH] Unichrome XvMC VLD support

[Ivan Kalvachev]

On Tue, 21 Sep 2004 21:43:16 +0000
Ivor Hewitt <ivor at ivor.org> wrote:

> Hi,
> This patch adds support for the unichrome VLD extension to the xvmc video out 
> driver.
> 
> Usage:
> configure --enable-xxmc
> mplayer -vo xvmc -vc ffpmeg12

mplayer -vo xvmc -vc ffmpeg12xxmc ;)

> 
> Regards,
> 
> -- 
> Ivor Hewitt.
> http://www.ivor.it - tech | http://www.ivor.org - hedge

Well sorry for not replying on your provious mail. I promise I will do it right away.
Now comments about the patch.

Look for the right set of options to use when making patch, 
Patch seems to apply but it looks funny when I'm watching it.

Don't remove xvmc from the _(no)vomodules. They are different interfaces anyway.

Always add new PIX_FMT_ at the end. The enum numbers are used by binary packages of
libavcodec and inserting new format will break compability.

you can use xvmc_acceleration with some bitmask or special value
(so far are used 0,1,2) to indicate the acceleration level.
This will keep unchanged some of the old if's and won't affect performance.

Why are you forcing the LIBMPEG2MMX idct algo? 
I'm not sure but it used some strange permutation.

Why are you creating new XVMC_VLD_field funtions, I already have
XVMC_field - it just makes the code bigger.

"#ifdebug" missing closing ] will be commited imidiatly

hadVLDAcceleration() is not used in the xvmc_check_surface_format.
but it is used on all other places.

"RenderSirface" will be commited imediatly

There are reserved fields in xvmc_render_state_t, use them and don't make
the structure bigger



Now about the whole VLD acceleration.
I would be happy if I should not commit it.
BTW it is good if you send the patch to FFmpeg-dev maillist so the project leader 
could say that he think about it. I guess he will be less happier than me:(
But if he accept it I will commit the whole patch.


Now I see proove that your XVMC_VLD don't have much in common with the original
XVMC simply most of the code is reimplemented and lots of rendering stuff is bypassed.
Something else, it is theoritically imposible to have all 3 levels of acceleration at once.


Will reply to the other thread, so we could flame without trashing
patch thread ;)

Wish You Best
   Ivan Kalvachev
  iive