[MPlayer-dev-eng] [COMMENTS?] MPlayer on Zeta OS

[Torinthiel]

On Wed, Sep 29, 2004 at 12:37:21AM +0200, Reimar Döffinger wrote:
> Hi,
> attached are a few patches that make MPlayer compile on Zeta OS... well
> somehow. Some manual intervention is neccessary, especially compiling a
> working gcc (their included gcc of a version that we all very much like 
>  just doesn't work. mplayerhq mail filters won't let me write the 
> actual version ;-)).
> These patches are all just more or less a hack, I'd like to get comments
> on which parts would be worth cleaning up and including them in CVS.

You've missed one occurrence of -lm in configure, in check for Toolame.
Also the configure and Makefile parts apply with a lot of offests.

> --- configure	Mon Sep  6 21:56:44 2004
> +++ configure	Sat Sep 11 21:26:40 2004
[cut]
> @@ -3602,11 +3642,11 @@
>  int main(void) { return 0; }
>  EOF
>    _svga=no
> -  cc_check  -lvgagl -lvga -lm && _svga=yes
> +  cc_check  -lvgagl -lvga $_lm && _svga=yes
>  fi
>  if test "$_svga" = yes ; then
>    _def_svga='#define HAVE_SVGALIB 1'
> -  _ld_svga='-lvgagl -lvga -lm'
> +  _ld_svga='-lvgagl -lvga $_lm'

This should be in double quotes. $_lm does not get expanded this way.

> diff -Nu osdep/swab.c osdep/swab.c
> --- osdep/swab.c	Thu Jan  1 00:00:00 1970
> +++ osdep/swab.c	Sat Sep 11 15:23:10 2004
> @@ -0,0 +1,16 @@
> +#include "../bswap.h"
> +
> +#ifndef	HAVE_SWAB

If you define HAVE_SWAB in config.h it probably would be wise to include
it.
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040929/d08695c8/attachment.pgp>