[MPlayer-dev-eng] [PATCH] "verbose" in libmpcodecs/pullup.c

[D Richard Felker III]

On Thu, Mar 31, 2005 at 09:45:27PM -0500, Yue Shi Lai wrote:
> D Richard Felker III schrieb:
> >On Thu, Mar 31, 2005 at 02:44:14PM -0500, Yue Shi Lai wrote:
> >
> >>Hi,
> >>
> >>The line that checks the global variable "verbose" is implemented wrong 
> >>in libmpcodecs/pullup.c. The fact that "verbose" is a _signed_ variable 
> >>is disregarded, which results in the undesired increasing verbosity with 
> >>a negative value.
> >
> >
> >it's not implemented wrong; verbose is a boolean flag. the way the
> >field is declared is irrelevant.
> 
> Sorry, apparently you do not know what I am talking about. Maybe you 
> should have a look on vf_pullup.c first:
> 
> 	c->verbose = verbose;
> 
> The global verbose is definitively not boolean. And in the mean time, 
> maybe you also want to try run the filter using -really-quiet (which 
> sets the global verbose to a negative value).

Oh, then this is a bug! I'll fix it.

> So, pullup being extra loud, while the user sets -really-quiet, is this 
> irrelevant?

No, not at all.

> >if you want to document the api for
> >pullup.c, feel free.. for now it's undocumented. :)
> 
> I am sorry: How are people supposed to document the API if your 
> statement is contradicted by the source code? By pure guessing?

If you had shown me that line to begin with, I would have agreed there
was a bug. The bug is just in vf_pullup.c, not pullup.c. Sorry for the
confusion. I'll go fix it.

Rich