[MPlayer-dev-eng] [patch] libvo configuration flags cosmetics
Alexander Strasser
eclipse7 at gmx.net
Sat Apr 9 13:50:19 CEST 2005
Jindrich Makovicka wrote:
> this is a quite large but trivial patch, changing the numerically
> specified VO & VF flags to the values #defined in video_out.h and
> vfcap.h. It can be classified as cosmetics, but using the numerical
> values is certainly a bad practice, so I believe it is reasonable to
> commit it.
>
> ok to commit?
I am ok with it for the files I am maintaining. I also doublechecked
the substitutions and they were all correct for these files.
Alex (beastd)
PS: I still remember myself being annoyed about this, when i started
studying mplayer code ;)
More information about the MPlayer-dev-eng
mailing list