[MPlayer-dev-eng] [PATCH] HRTF filter enhancements

[Jindrich Makovicka]

Yue Shi Lai wrote:

> +    if(counter++ == 0) {
> +       if(s->decode_mode == 2)
> +	  af_msg(AF_MSG_INFO,
> +		 "[hrtf] Using active matrix to decode 2 channel "
> +		 "input\n");
> +       if(s->decode_mode == 1)
> +	  af_msg(AF_MSG_INFO,
> +		 "[hrtf] Using HRTF to mix %s discrete surround into "
> +		 "L, R channels\n", s->matrix_mode ? "5" : "5+1");
> +       else
> +	  af_msg(AF_MSG_INFO,
> +		 "[hrtf] Using HRTF to mix stereo into "
> +		 "L, R channels\n");
> +       if(s->matrix_mode)
> +	  af_msg(AF_MSG_INFO,
> +		 "[hrtf] Using active matrix to decode rear center "
> +		 "channel\n");
> +    }
> +

I think there is a missing else before if(s->decode_mode == 1) causing
the filter display a misleading message when downmixing 5.1. You should
better use switch(s->decode_mode) and also display some warning when
decode_mode != 0,1,2 just to be sure.

-- 
Jindrich Makovicka