[MPlayer-dev-eng] [PATCH] HRTF filter enhancements

[Yue Shi Lai]

Yue Shi Lai schrieb:
> Jindrich Makovicka schrieb:
> 
>> I think there is a missing else before if(s->decode_mode == 1) causing
>> the filter display a misleading message when downmixing 5.1. You should
>> better use switch(s->decode_mode) and also display some warning when
>> decode_mode != 0,1,2 just to be sure.
> 
> 
> No, I think the logic is correct here:
> 
> decode_mode == 2 means 2 channel becomes 5 channel surround
> Then for both decode_mode == 0 (was 5 ch, is still 5 ch) and decode_mode 
> == 2 (was 2 ch, is now 5 ch): Use 5 channel HRTF mix. The matrix 
> decoding does not substitute the final HRTF mix. And in fact I avoided 
> case on purpose, because of this mind twisting logic. ;-)

Ups, you are right in the message issue: The message displayed is indeed 
incorrect. And the problem is: it should be if(s->decode_mode != 1)

Thanks!