[MPlayer-dev-eng] [PATCH] HRTF filter enhancements

[Jindrich Makovicka]

Yue Shi Lai wrote:
> Yue Shi Lai schrieb:
> 
>> Ups, you are right in the message issue: The message displayed is
>> indeed incorrect. And the problem is: it should be if(s->decode_mode
>> != 1)
> 
> 
> There is in fact a related problem I just found. The subsequent lines
> should be:
> 
>        if(s->decode_mode != 1)
>           af_msg(AF_MSG_INFO,
>                  "[hrtf] Using HRTF to mix %s discrete surround into "
>                  "L, R channels\n", s->matrix_mode ? "5+1" : "5");
> 
> The s->matrix_mode conditional was flipped.

I am confused. Which message should be displayed then when
decode_mode==2 ? Both
"Using active matrix to decode 2 channel input" and "Using HRTF to mix
%s discrete surround into ..." ?

Please look at the attached patch - it

1) #defines the decode modes
2) converts all the decode_mode if's to switches so it's immediately
clear which case is which and every one is really handled
3) removes the ugly static counter and resets the flag every time
control() is called

Otherwise, HRTF looks very interesting, but your patch definitely needs
some (trivial) polishing.

Also, please make sure that the patch applies to current CVS. I had to
apply one hunk by hand. I hope you will be able to apply my patch on
your copy.

Regards,
-- 
Jindrich Makovicka
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: af_hrtf.c.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050409/22cf23d8/attachment.asc>