[MPlayer-dev-eng] [PATCH] HRTF matrix decoder enhancements

Jindrich Makovicka makovick at kmlinux.fjfi.cvut.cz
Mon Apr 11 17:08:39 CEST 2005


Diego Biurrun wrote:
> On Mon, Apr 11, 2005 at 04:05:13PM +0200, Jindrich Makovicka wrote:
> 
>>Please, could you also write some documentation to the manual page,
>>especially clarify the filter options?
> 
> 
> What's missing?  Please don't commit patches with incomplete documentation,
> it's also a requirement mentioned in DOCS/tech/patches.txt.  Just tell the
> patch sender to also update the docs, works fine in almost all cases.

I added a terse description of the options to the manual page before,
but it should be reviewed by the author.

> Shouldn't the comments be doxygen compatible?

I can reformat them to be, if Yue wouldn't. But otherwise the code is
commented very well, i guess quite above MPlayer standards :)

-- 
Jindrich Makovicka




More information about the MPlayer-dev-eng mailing list