[MPlayer-dev-eng] [PATCH] unrarlib on AMD64

[Alexander Strasser]

Diego Biurrun wrote:
> On Sun, Apr 17, 2005 at 05:35:18PM +0200, Jindrich Makovicka wrote:
> > Rich Felker wrote:
> > > On Sun, Apr 17, 2005 at 04:37:32PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > 
> > >>On Sunday, 17 April 2005 at 11:37, Jindrich Makovicka wrote:
> > >>>
> > >>>What about adding an (optional) support for rar executable, instead of
> > >>>unrarlib? Recent rars cannot be read by unrarlib anyway.
> > >>
> > >>Because we strive not to require proprietary libs/tools. Though unrar
> > >>source is available, the license is not GPL compatible. No rar3 support
> > >>is planned in unrarlib, so we just have to live with it or write rar3
> > >>decompression routines ourselves.
> > > 
> > > i propose the latter, and adding rar3 compression routines while we're
> > > at it. :)
> > 
> > another option is to ditch rar support, import decompression routines
> > from bzip2 and provide migration scripts :) bzip2 compresses vobsubs
> > better anyway.
> 
> I know this is going to sound heretical, but how useful is this feature
> anyway?  I have yet to come across rared subtitles and what speaks
> against uncompressing them before movie playback?  Movies are also
> unrared before watching...

  Movies shouldn't be rared anyway. AFAIK there are many rared subs
floating around and decompressing them on the fly should pose no
problems except if we can't incorporate the decompressor as in this
case...

  Alex (beastd)