[MPlayer-dev-eng] Re: [PATCH] codecs.conf AMR change

[adland123]

Roberto Togni <r_togni <at> tiscali.it> writes:

> 
> This fix works, but i'm not sure it's the best one.
> 0x12000 is the value of CODEC_ID_AMR_NB, that's part of the codec ids
> enum in lavc. I have no idea why the amr demuxer (in lavf) put the
> codec id also in the tag field.
> I'll mail to ffmpeg-devel to ask if it's ok to fix it so that it puts
> the right fourcc (samr), or at least to leave it empty so that i can
> convert it via avienc.c

Okay thanks for looking into this.
It looks like there is no specific fourcc inside an AMR file.
You can however derive the valid fourcc (samr or sawb) from the first few bytes
#!AMR or #!AMR-WB.

> I put the samples in samples/amr/ on mphq, btw sample2.amr and
> whatireallywant.amr does not work in mplayer but work ok in ffplay, i
> still have to check why.

Thanks for doing this file upload.
For me all samples played fine with MPlayer after the  change.
unsure if we are using the same code?

The what I really want amr file was adult themed by the way.
I can always retest these with todays newer CVS build.

> 
> Ciao,
>  Roberto
>