[MPlayer-dev-eng] a52 codec with divx causing segfault in mplayer

[Meihui Fan]

Aurelien Jacobs wrote:
> On Tue, 9 Aug 2005 02:25:16 -0700
> "C.Y.M" <syphyr at gmail.com> wrote:
> 
> 
>>On 8/9/05, Bohdan Horst <nexus at hoth.amu.edu.pl> wrote:
>>
>>>On Mon, Aug 08, 2005 at 04:21:54PM -0700, C.Y.M wrote:
>>>
>>>>It appears that there is a problem with mplayer and the following
>>>>video format.  Other XVID files play fine. The problem seems to be
>>>>with a52 audio.  This causes mplayer to segfault.
>>>>
>>>
>>>which mplayer version?
>>>
>>>please try:
>>>
>>>cd main/liba52
>>>patch -R < liba52_amd64_changes.diff
>>>
>>>and recompile ?
>>>
>>>regards
>>>
>>>(on my P3 a52 audio is broken since latest amd64 commits..)
>>>
>>
>>I am using current CVS of mplayer.  I just reversed the amd64 changes
>>in liba52 and now it works perfectly again.  My system is an i386 with
>>gcc-3.4.  Thank you very much. :)
> 
> 
> I wasn't able to reproduce the problem but I think the attached patch
> could fix it.
> Could you please test this patch ?
Yes, this patch seems work in my here.
> 
> Aurel
> 
> 
> ------------------------------------------------------------------------
> 
> Index: imdct.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/liba52/imdct.c,v
> retrieving revision 1.28
> diff -u -r1.28 imdct.c
> --- imdct.c	5 Aug 2005 13:33:49 -0000	1.28
> +++ imdct.c	9 Aug 2005 11:46:06 -0000
> @@ -813,7 +813,7 @@
>  		"sub $16, %%"REG_D"			\n\t"
>  		"jnc 1b				 	\n\t"
>  		"pop %%"REG_BP"				\n\t"//no we didnt touch ebp *g*
> -		:: "r" (data), "r" (buf)
> +		:: "b" (data), "c" (buf)
>  		: "%"REG_S, "%"REG_D, "%"REG_a, "%"REG_d
>  	);
>  
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-- 
Best Regards,
范美辉 (Meihui Fan)