[MPlayer-dev-eng] [PATCH] support for libXvMCW wrapper library

[Dominik 'Rathann' Mierzejewski]

On Sunday, 21 August 2005 at 03:10, Wes Shull wrote:
> libXvMCW is a wrapper which dlopens a proper libXvMC at runtime (which
> one it loads is configurable); it eliminates the need to link directly
> against a hardware-specific xvmc lib to support it.
> 
> The library originated in the Unichrome driver project (
> http://unichrome.sourceforge.net/ ) but is useful for nvidia, etc.
> too.  It's in ATrpms, probably other places too.
> 
> Attached is a pretty simple mostly cut&paste patch to enable its use
> with mplayer.  It adds an --enable-xvmcw (and --disable-xvmcw) option,
> which must be used in conjunction with --enable-xvmc.

IMHO --enable-xvmcw should imply --enable-xvmc, but that's debatable.
OTOH, since this is a generic library, not something hardware-dependent,
it could be set to autodetection, since enabling it doesn't require
any user input like with plain XvMC (where you need to specify the
name of the library explicitly).

> The patch is directly against configure, from today's (anon) cvs,
> which feels very wrong to me--it should be against configure.in. 
> Except I can't find that.

You shouldn't be surprised, given the fact that MPlayer doesn't use
auto* tools, including autoconf.

> This is my first patch submission to mplayer.  Flame away ;-)

Looks nice otherwise.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"