[MPlayer-dev-eng] [PATCH] Exit if preinit of af chain fails

[Michael Niedermayer]

Hi

On Mon, Aug 22, 2005 at 05:56:24PM +0300, Ivan Kalvachev wrote:
> 2005/8/17, Ivo <ivop at euronet.nl>:
> > On Thursday 11 August 2005 01:52, Ivo wrote:
> > > Hi,
> > >
> > > If you specify audio filters on the command line and one or more of them
> > > fail to initialize, MPlayer only prints an error but continues to run
> > > with undefined results. For example, try -af pan (no suboptions). It just
> > > hangs.
> > >
> > > Attached patch fixes this. OK to commit?
> > 
> > Any comments on this? It changes the behaviour of MPlayer (for the better
> > IMHO).
> > 
> > If not, I'll commit it in a day or two :)
> 
> Ask al3x about audio system.
> 
> If you ask me, I think it is wrong to kill mplayer because some filter
> cannot init. It would be better if this filter is just not used.

disagree, mplayer should fail if a filter fails
its very lame to spend a few hours encoding and then notice that audio
hasnt been resampled or its volume corrected ...

[...]
-- 
Michael