[MPlayer-dev-eng] [RFC] including x264 with MPlayer tarballs

[Guillaume POIRIER]

Hi,

On 8/22/05, Rich Felker <dalias at aerifal.cx> wrote:
> On Mon, Aug 22, 2005 at 09:29:03PM +0200, Jindrich Makovicka wrote:
> > Guillaume POIRIER wrote:
> > > Hi,
> > >
> > > On 8/22/05, Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz> wrote:
> > >>I have x264 CVS compilation inside mencoder integrated in my build
> > >>script for about half a year (together with Theora & FAAC). I can send a
> > >>patch if you like.
> > >
> > > Sure, I'd love that!
> >
> > Ok.. buildmplayer is the actual build script. Just cut out the X264
> > section, ignore the rest. The other files are the contents of the
> > ~/devel/patches/mplayer-x264/ directory, which are used in the script.
> > CVS checkout of X264 is expected to be in ~/CVS/x264/x264/. So when run,
> > the script should make x264 subdirectory in MPlayer build, copy x264
> > into it, create the x264 Makefile and patch configure and MPlayer's
> > Makefile.
> >
> > Issues: 1) NASM detection is pretty fake. It should at least assemble
> > some trivial input.
> 
> :(
> I'm mildly against including code in mplayer cvs if it depends on nasm
> or other obscure compiletime tools. It's better not to clutter the
> configure system and let users compile strange external stuff
> separately, like live.com and the c++ mess..

Actually, if I'm not mistaken: x264 IA-32 needs nasm, when x264 AMD-64
needs yasm.

Guillaume
-- 
Live fast, die old, and make very sure everyone knows you were there.
 -- Alan Cox