[MPlayer-dev-eng] [PATCH] Problem using libavcodec.so

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 23 August 2005 at 17:31, Ivan Kalvachev wrote:
> 2005/8/18, Diego Biurrun <diego at biurrun.de>:
> > On Mon, Aug 15, 2005 at 05:53:12PM +0200, Panagiotis Issaris wrote:
> > >
> > > For some time now, mencoder CVS failed to link dynamically to libavcodec.so:
> > >
> > > cc -I../libvo -I../../libvo -I/usr/X11R6/include -fno-PIC -O4
> > > [...]
> > > libmpcodecs/libmpencoders.a(ae.o)(.text+0xb9): In function
> > > `new_audio_encoder':
> > > : undefined reference to `mpae_init_lavc'
> > > collect2: ld returned 1 exit status
> > >
> > > This seems to be caused by libmpencoders.a not containing ae_lavc.o.
> > >
> > > The attached patch contains a fix for this.
> > 
> > Thanks, applied.
> 
> DonDiego, please don't apply patches blindly.
> 
> There is something wrong in this patch. The problem is that right
> before the new Makefile line there is line that does the same if there
> is ANY libavcodec.
> The question is why it doesn't work, but the separate *SO one does.

I have to agree here. This patch is definitely wrong, even if it does seem
to fix this particular case.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"