[MPlayer-dev-eng] Re: [PATCH] Pivoting

[Paweł Sakowski]

OK, another approach:

- mplayer-pivot.patch: to detect the rotation, I use libXrandr directly.
This introduces a library dependency, but (as per the library design)
does not require support in the X server. Again, I don't know how RandR
interacts with Xinerama, so I'm not changing the behavior of the latter.

- mplayer-aspect.patch: monitor_aspect is taken from (in the order of
precedence):
1. explicit specification in config or command-line
2. physical width/height as reported by vo (currently only implemented
for X11-based vo, using DisplayWidthMM)
3. square pixel assumption

Display{Width,Height}MM seem always to return sane values. If there's no
authoritative source of the display's size, they simply calculate it
from the pixel count and some pressumed dpi.

pivot.patch works for me just fine. There's a problem with aspect.patch
that monitor_aspect detection doesn't work well for -vo aa. I'm not sure
how to solve it. It looks like vo_aa doesn't report screen width/height
that would actually correspond to the amount of the characters it
actually displays. Could somebody with knowledge of libaa look into
this? Note: even before my changes, vo_aa wouldn't preserve the aspect
well e.g. if the X window gets resized.

If there's no straightforward solution using libaa features, I would opt
for sticking with the 4:3 assumption for aa and detecting monitor_aspect
for other vos (which is as simple as applying my patch and inserting
"vo_physical_width=4; vo_physical_height=3;" somewhere in vo_aa.c).

-- 
+----------------------------------------------------------------------+
| Paweł Sakowski <pawel at sakowski.pl>                Never trust a man  |
|                            who can count up to 1023 on his fingers.  |
+----------------------------------------------------------------------+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-aspect.patch
Type: text/x-patch
Size: 2409 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050824/dd5b457b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-pivot.patch
Type: text/x-patch
Size: 3822 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050824/dd5b457b/attachment-0001.bin>