[MPlayer-dev-eng] [PATCH] MPEG-ES in GXF demuxer

[Nico Sabbi]

Reimar Döffinger wrote:

>Hi,
>On Thu, Aug 25, 2005 at 12:35:18PM +0200, Nico Sabbi wrote:
>  
>
>>uhm, 0x1b[cf] are startcodes used to identify PSM and padding streams, 
>>so they are valid
>>mpeg-ps stream identifiers. With your code there will be collisions and 
>>fake detections.
>>    
>>
>
>Sure, I have no clue about this stuff...
>
>  
>
>>BTW, what's the format of gfx? can't you just associate the extension 
>>with DEMUXER_TYPE_MPEG_ES?
>>    
>>
>
>Don't know the details, but MPEG_ES will not work since there can be
>"start codes" in between a 0x1bf and the next 0x100 that should be
>ignored.
>Use -vc ffmpeg12, you will see a lot of qscale==0 errors and it will
>not play right.
>
>Greetings,
>Reimar Döffinger
>
>  
>
the file plays but yes: ffmpeg12 complains.
In this case you can follow my second advice: a new probing function to 
be called
in the new demuxer_desc structure (in a later position than mpeg*) and 
the same
seek() / read() functions as mpeg*, but please: move the code to exclude
all content from 0x1b[cf] and 0x100 away from video.c and into 
demux_mpg.c (as a special case).

    Nico
 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Digitalpix stampa le tue migliori foto digitali 
* su vera carta fotografica professionale.
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=1532&d=25-8