[MPlayer-dev-eng] [patch] malloc padding

Ivan Kalvachev ikalvachev at gmail.com
Tue Dec 20 23:21:48 CET 2005


2005/12/19, Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz>:
> On 12/19/05, Diego Biurrun <diego at biurrun.de> wrote:
> > On Sat, Dec 17, 2005 at 06:45:07PM +0100, Jindrich Makovicka wrote:
> > >
> > > this patch adds the malloc padding to several places to avoid reading
> > > past the malloc()ed area by libavcodec.
> > >
> > > Credits to Mikulas Patocka (mikulas at artax karlin mff cuni cz)
> >
> > Is this the patch from this bug report?
> >
> > http://bugzilla.mplayerhq.hu/show_bug.cgi?id=264
> >
> > If not, please check it out as well.
>
> Yes, this is the mplayer part, updated to apply to current CVS. The
> libavformat part has been applied yesterday.
>
> Regards,
> --
> Jindrich Makovicka

You are hurring too much...
I would like to ask two things:

1. If the problem is only in extradata why this patch messes with the
demuxers? AFAI can see the extradata is copied in the v?_ffmpeg to the
allocated&padded  buffer.

2. In case this align is needed for bitstream data too....
then why the bug is not fixed in the ffmpeg instead of hacking random
places in the players.




More information about the MPlayer-dev-eng mailing list